Fix connection with non sqlite db #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any updates on this? |
|
Hey sorry, I've been absent from Plombery for a while, but I'm getting back! Thanks for the PR, sounds good to me, @PierrickBrun can you just black-format your code so the unittests pass? |
lucafaggianelli
requested changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #363
This MR allows to connect to non-sqlite databases.
I ran the tests after the modification and they all passed.
I also ran the tests on an empty postgresql DB and they all passed except
tests/test_logging.py::test_pipeline_logs_are_correclty_captured.All the logs appear in double, but the tasks are not doubled in the db.
The logs are not duplicated in the example app running on postgres too.
The same problem appears when I use sqlite as a file (opposed to an in-memory db). So I guess we can ignore this problem and consider postgres as working.