update package dependecies and add verbose flag #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new a11y version uses phantomjs v2.x which bin is compatible with MacOS Sierra, whereas v1.9 currently gives segmentation fault error, preventing tests run
srescio
changed the title
|
@srescio thanks again for your PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
latest MacOS version no longer support running PhantomJS v1.9.x which fails with a segmentation fault error, while newer version v2.x is not affected
since a11y dependency requires the broken version it's not possible to execute it on latest mac, by updating a11y to 0.5 which relies on a newer version the issue is solved,
added also verbose flag to see the full output (default is false)
@lucalanca