change default to auto_file_sync: true #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaong
force-pushed
the
file_sync_by_default
branch
from
62a8cd1
to
c71b368
Compare
This uses the safer (but slower on writes) option by default, and require the user to manually decide when they prefer write performance over strict durability of writes.
lucaong
force-pushed
the
file_sync_by_default
branch
from
c71b368
to
0eb8725
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the safer (but slower on writes) option by default, and
require the user to manually decide when they prefer write performance
over strict durability of writes.