Better timeouts #16
Merged
Better timeouts #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucaong
force-pushed
the
better_timeouts
branch
3 times, most recently
from
9fe6698
to
5df3d3b
Compare
Rather than relying on the GenServer.call timeout, that exits the caller but does not free up resources on the callee, this commit enforces the timeout also on the callee side when performing reads. Also `get_and_update_multi/4` now enforces a timeout on the callee side. This commit also cleans up the public API around timeouts by introducing a breaking change, as both `select/2` and `get_and_update_multi/4` now accept the timeout as an option instead of a separate argument. This allows to introduce more options in the future, without having to introduce more breaking changes. The reader check in and check out is also refactored to be substantially simpler.
lucaong
force-pushed
the
better_timeouts
branch
from
5df3d3b
to
917f13c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than setting arbitrary GenServer timeouts (which would crash the
caller but not stop the callee), enforce better timeouts that free up
resources when they elapse.
The
Readertask is also greatly simplified, moving the responsibility tocheck in/out readers in a single place in the
CubDBmodule.This commit introduces a breaking change to the public API, as both
select/2andget_and_update_multi/4now accept the timeout as anoption instead of a separate argument. This allows adding more options
in the future without having to change the number of arguments.