[breaking change] improve the select/3 API for key ranges #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous API had a few shortcomings:
Corner cases for
nil
min_key/max_key andmin_key
/max_key
literally being tuples like{123, :included}
Misspelling
:included
or:excluded
would silently fail or lead to unexpected resultsThe API was a bit cumbersome in general
See also the discussion here: #3
The new API is much clearer, and removes the shortcomings: