Let users specify git reference as buildarg #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cormier, can you please let by default the ojs tag (ojs-3_1_1-4) as default in the ARG? so it won't happen build problems when i merge. Thanks for your help @cormier |
This commit introduces a ``ref`` argument that let the users specify the git reference (can be a branch, a tag, the SHA-1 of a commit) that they want to use. The default value of the ``ref`` argument is master, meaning the latest version of OJS will always be used.
|
I have updated my commit to replace |
|
Great addition. Thanks @cormier and @lucasdiedrich |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit introduces a
refargument that let the users specify thegit reference (can be a branch, a tag, the SHA-1 of a commit) that they
want to use.
The default value of the
refargument is master, meaning the latestversion of OJS will always be used.