Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let users specify git reference as buildarg #32

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Let users specify git reference as buildarg #32

merged 1 commit into from
Apr 17, 2019

Conversation

cormier
Copy link
Contributor

@cormier cormier commented Apr 16, 2019

This commit introduces a ref argument that let the users specify the
git reference (can be a branch, a tag, the SHA-1 of a commit) that they
want to use.

The default value of the ref argument is master, meaning the latest
version of OJS will always be used.

@lucasdiedrich
Copy link
Owner

Cormier, can you please let by default the ojs tag (ojs-3_1_1-4) as default in the ARG? so it won't happen build problems when i merge.

Thanks for your help @cormier

This commit introduces a ``ref`` argument that let the users specify the
git reference (can be a branch, a tag, the SHA-1 of a commit) that they
want to use.

The default value of the ``ref`` argument is master, meaning the latest
version of OJS will always be used.
@cormier
Copy link
Contributor Author

cormier commented Apr 16, 2019

I have updated my commit to replace master with ojs-3_1_1-4.

@marcbria
Copy link
Contributor

Great addition. Thanks @cormier and @lucasdiedrich

@lucasdiedrich lucasdiedrich merged commit cbbc212 into lucasdiedrich:master Apr 17, 2019
@cormier cormier mentioned this pull request Apr 17, 2019
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants