Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for laravel 10 #57

Merged
merged 8 commits into from
Apr 7, 2023

Conversation

omaressaouaf
Copy link
Contributor

@omaressaouaf omaressaouaf commented Mar 10, 2023

This pull request bumps dependencies to support Laravel 10. it also modifies the run-tests.yml github action to run tests on Laravel 10 as well

@lucasdotvin lucasdotvin self-requested a review March 12, 2023 15:11
@lucasdotvin lucasdotvin added enhancement New feature or request good first issue Good for newcomers labels Mar 12, 2023
@lucasdotvin
Copy link
Owner

Hey! Thanks for the contribution! I'm running some tests to ensure everything is working then it'll be merged!

@omaressaouaf
Copy link
Contributor Author

This package depends on another package of yours (laravel-database-queries-counter) which itself needs to support Laravel 10. I opened another pull request on laravel-queries-counter to support Laravel 10. then if you can tag a release in order to come back to this one and modify the dependency

@ejjaquet
Copy link

ejjaquet commented Apr 6, 2023

Any news about this update? I really want to use this package, but it won't let me install on Laravel 10...

@omaressaouaf
Copy link
Contributor Author

Unfortunately the maintainer does not respond. so i had to fork it and use my own repo

@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #57 (939c98d) into develop (82d5e3e) will not change coverage.
The diff coverage is n/a.

❗ Current head 939c98d differs from pull request most recent head c22d9bb. Consider uploading reports for the commit c22d9bb to get more accurate results

@@            Coverage Diff             @@
##             develop      #57   +/-   ##
==========================================
  Coverage      98.20%   98.20%           
  Complexity       150      150           
==========================================
  Files             26       26           
  Lines            501      501           
==========================================
  Hits             492      492           
  Misses             9        9           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@omaressaouaf
Copy link
Contributor Author

I think everything is fine ?

@lucasdotvin
Copy link
Owner

For some reason, it is not running the test suite for PHP 8.1 with Laravel 10. I'm going to push another commit and see how it goes.

@lucasdotvin lucasdotvin merged commit dbf3636 into lucasdotvin:develop Apr 7, 2023
@lucasdotvin
Copy link
Owner

Thank you guys for your patience! 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants