Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels for all components and for connections #5

Closed
trstruth opened this issue Jun 24, 2020 · 2 comments
Closed

Labels for all components and for connections #5

trstruth opened this issue Jun 24, 2020 · 2 comments
Labels
bug Something isn't working

Comments

@trstruth
Copy link

What is the reasoning behind only supporting labels on a subset of the components? Would it be possible to extend label support to all of them?

Additionally, could connections support labels as well?

@trstruth trstruth changed the title Labels for all components and for edges Labels for all components and for connections Jun 24, 2020
@lucasepe
Copy link
Owner

Components: Totally agree! Actually I'm working on it. In the next release each component will be able to handle labels.

Connections: they "should" already support labels (if something does not works please let me know, I'll fix it asap).

type Connection struct {
  Origin string `yaml:"origin"`
  Targets []struct {
    ID          string `yaml:"id"`
    Label       string `yaml:"label,omitempty"`
    Color       string `yaml:"color,omitempty"`
    Dashed      bool   `yaml:"dashed,omitempty"`
    Dir         string `yaml:"dir,omitempty"`
    Highlight   bool   `yaml:"highlight,omitempty"`
  } `yaml:"targets"`
}

@lucasepe lucasepe added the bug Something isn't working label Jun 25, 2020
@lucasepe
Copy link
Owner

Fixed with release v0.7.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants