Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Several fix and improvement #50

Merged
merged 25 commits into from
Aug 5, 2024
Merged

Several fix and improvement #50

merged 25 commits into from
Aug 5, 2024

Conversation

r0ngk
Copy link
Contributor

@r0ngk r0ngk commented Jun 4, 2024

See commit

r0ngk added 23 commits June 1, 2024 13:14
@r0ngk
fix linux path error "\\"
0804f98
@r0ngk
fix checking of 64bit java in linux using "file" instead of trying to…
8530b5a 
… execute potential .exe file
@r0ngk
fix and group JVM patch linux pathing
50926e0
@r0ngk
remove a useless import
fdee156
@r0ngk
fix KL cannot restart after choosing to patch java in linux
15ce0b2
@r0ngk
fix KL cannot obtain java release data under linux
0c365b0
@r0ngk
change KL to use steam to launch directly instead of relying on jre l…
4b7aeb9 
…ibrary
@r0ngk
Add function to create linux .desktop shortcut
41738ae
@r0ngk
fix use of blacks lash instead of forward slash of checking safeguard…
f696105 
… file exist
@r0ngk
fix \\ pathing problem for the module "jar" and related code
c453fc7
@r0ngk
Avoid extracting jar when jar already exist
7171d3b
@r0ngk
fix a missing not symbol
7e6d138
@r0ngk
detect and change java folder to java_vm to unite the path
9ed6558
@r0ngk
change default non-steam launch path of java
da463bb
@r0ngk
jvm executable path for non .exe
c2d2db5
@r0ngk
remove potential double calling of rebuild file
253ee4c
@r0ngk
remove double calling of update mod list gui
702ecd8
@r0ngk
remove unnecessary mount mod in refresh event
e856ca0
@r0ngk
remove a useless function because disabled mod is not parse at that m…
9c307dd 
…oment
@r0ngk
check hash of set of mods instead of counting
ac2ec87
@r0ngk
remove a useless pre-rebuilding of game file and implement the settin…
7f9928f 
…g of clean file correctly
@r0ngk
remove multi-thread of file rebuild to avoid a race condition with mount
29bc796
@r0ngk
change to use xdg-utils to open website instead of relying on jre des…
07e3b06 
…ktop browse (libgome2)
@lucasluqui
Copy link
Owner

Thank you for your contributions! I'll be reviewing and merging as soon as I can.

@lucasluqui lucasluqui self-assigned this Jun 4, 2024
@lucasluqui lucasluqui added the good first issue Good for newcomers label Jun 4, 2024
@lucasluqui lucasluqui self-requested a review June 4, 2024 14:52
@Crowfunder
Copy link
Contributor

While I understand why it's better to have java in the same folder on all platforms I'm not exactly sure if renaming the entire vm folder is a good idea, may cause issues if user decides to uninstall KL.

@r0ngk
Copy link
Contributor Author

r0ngk commented Jun 4, 2024

While I understand why it's better to have java in the same folder on all platforms I'm not exactly sure if renaming the entire vm folder is a good idea, may cause issues if user decides to uninstall KL.

sure can fix that

@lucasluqui lucasluqui merged commit 0aaf48c into lucasluqui:2.0 Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucasluqui lucasluqui Awaiting requested review from lucasluqui

Assignees

@lucasluqui lucasluqui

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@r0ngk @lucasluqui @Crowfunder