Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reload 404 error. Implemented getServersideProps() to access content #68

Merged
merged 1 commit into from
Mar 16, 2023

Conversation

romeshkosme
Copy link
Contributor

ℹ️ Repository information

Implemented getServerSideProps to access the data from JSON file.

The repository has:

  • At least three issues with the good first issue, or other labels specified in firstissue.json (see labels and the end).
  • Link:
  • At least 10 contributors.
  • At least 1000 stars.
  • Detailed setup instructions for the project.
  • Link:
  • CONTRIBUTING.md
  • Actively maintained (last updated less than 1 months ago).

@lucavallin
Copy link
Owner

@romeshkosme Thanks for your contribution! I am just back from my holidays - I will have a look at the PR soon. 🙏🏼 again for the refactoring!

@lucavallin
Copy link
Owner

Hello! I tested these changes, but getServersideProps does not work when the site is being exported as static html. Since the website is static, this fix won't do it here. Are there alternatives?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants