LDEV-2127 use stringbuilder for bytecode #1758
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zspitzer
force-pushed
the
LDEV-2127-stringbuilder-bytecode
branch
from
d58b76f
to
374d8ff
Compare
zspitzer
force-pushed
the
LDEV-2127-stringbuilder-bytecode
branch
from
374d8ff
to
d38dbdd
Compare
# Conflicts: # loader/build.xml # loader/pom.xml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # core/src/main/java/lucee/runtime/osgi/BundleRange.java # loader/build.xml # loader/pom.xml
# Conflicts: # loader/build.xml # loader/pom.xml
# Conflicts: # core/src/main/java/META-INF/MANIFEST.MF # loader/build.xml # loader/pom.xml
# Conflicts: # core/src/main/java/resource/tld/core-cfml.tld # core/src/main/java/resource/tld/core-lucee.tld # loader/build.xml # loader/pom.xml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # loader/build.xml # loader/pom.xml
# Conflicts: # loader/build.xml # loader/pom.xml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
| adapter.newInstance(Types.STRING_BUILDER); | ||
| adapter.dup(); | ||
| adapter.invokeConstructor(Types.STRING_BUILDER, CONSTR_NO_STRING); | ||
| _writeOutAppend(adapter, bc, mode, left); |
There was a problem hiding this comment.
there should be only one "append" and "left" should be passed into the constructor of StringBuilder
| // op._writeOut(bc, MODE_REF); | ||
| op._writeOutAppend(adapter, bc, mode, op.left); | ||
| op._writeOutAppend(adapter, bc, mode, op.right); | ||
| } |
There was a problem hiding this comment.
there must be an else
zspitzer
force-pushed
the
LDEV-2127-stringbuilder-bytecode
branch
from
d38dbdd
to
9a9b916
Compare
zspitzer
added a commit
to zspitzer/Lucee
that referenced
this pull request
Feb 20, 2024
refiled from lucee#1758 as rebase got ugly) https://luceeserver.atlassian.net/browse/LDEV-2127 code review comments still pending
|
closing due to ugly rebase, see #2315 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
from brucekirkpatrick@474ecd9
https://luceeserver.atlassian.net/browse/LDEV-2127