-
-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LDEV-2127 use stringbuilder for bytecode #1758
Conversation
d58b76f
to
374d8ff
Compare
374d8ff
to
d38dbdd
Compare
# Conflicts: # loader/build.xml # loader/pom.xml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # core/src/main/java/lucee/runtime/osgi/BundleRange.java # loader/build.xml # loader/pom.xml
# Conflicts: # loader/build.xml # loader/pom.xml
# Conflicts: # core/src/main/java/META-INF/MANIFEST.MF # loader/build.xml # loader/pom.xml
# Conflicts: # core/src/main/java/resource/tld/core-cfml.tld # core/src/main/java/resource/tld/core-lucee.tld # loader/build.xml # loader/pom.xml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
# Conflicts: # loader/build.xml # loader/pom.xml
# Conflicts: # loader/build.xml # loader/pom.xml
# Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
adapter.newInstance(Types.STRING_BUILDER); | ||
adapter.dup(); | ||
adapter.invokeConstructor(Types.STRING_BUILDER, CONSTR_NO_STRING); | ||
_writeOutAppend(adapter, bc, mode, left); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there should be only one "append" and "left" should be passed into the constructor of StringBuilder
// op._writeOut(bc, MODE_REF); | ||
op._writeOutAppend(adapter, bc, mode, op.left); | ||
op._writeOutAppend(adapter, bc, mode, op.right); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there must be an else
d38dbdd
to
9a9b916
Compare
refiled from lucee#1758 as rebase got ugly) https://luceeserver.atlassian.net/browse/LDEV-2127 code review comments still pending
closing due to ugly rebase, see #2315 |
from brucekirkpatrick@474ecd9
https://luceeserver.atlassian.net/browse/LDEV-2127