-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Add Lucide-Svelte icon import instructions and type definitions #1766
docs: Add Lucide-Svelte icon import instructions and type definitions #1766
Conversation
Great! Maybe a link to the Svelte doc to the ComponentType would be nice? Apart from that, it seems perfect to me. Link : https://svelte.dev/docs/typescript#types-componenttype |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome thanks a lot, I've a small improvement for the examples
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also rename the types?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work!
What is the purpose of this pull request?
Description
Following the conversations in #1761 & #1585, this improves the docs around the areas of type definitions and import statements.
If there are any modifications you wish for me to carry out, please let me know. 🙂
Before Submitting