Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Add Lucide-Svelte icon import instructions and type definitions #1766

Merged
merged 4 commits into from
Jan 3, 2024
Merged

docs: Add Lucide-Svelte icon import instructions and type definitions #1766

merged 4 commits into from
Jan 3, 2024

Conversation

shyakadavis
Copy link
Contributor

@shyakadavis shyakadavis commented Dec 28, 2023

What is the purpose of this pull request?

  • New Icon
  • Bug fix
  • New Feature
  • Documentation update
  • Other:

Description

Following the conversations in #1761 & #1585, this improves the docs around the areas of type definitions and import statements.

If there are any modifications you wish for me to carry out, please let me know. 🙂

Before Submitting

@github-actions github-actions bot added 📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website labels Dec 28, 2023
@lolcabanon
Copy link

Great! Maybe a link to the Svelte doc to the ComponentType would be nice? Apart from that, it seems perfect to me.

Link : https://svelte.dev/docs/typescript#types-componenttype

Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome thanks a lot, I've a small improvement for the examples

docs/guide/packages/lucide-svelte.md Outdated Show resolved Hide resolved
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also rename the types?

docs/guide/packages/lucide-svelte.md Outdated Show resolved Hide resolved
docs/guide/packages/lucide-svelte.md Outdated Show resolved Hide resolved
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work!

@ericfennis ericfennis merged commit 5989311 into lucide-icons:main Jan 3, 2024
2 checks passed
@shyakadavis shyakadavis deleted the docs/improve-sveltekit-docs branch January 3, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📖 documentation Improvements or additions to documentation 🌍 site Has to do something with the Lucide website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants