Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more music icons and another mic icon #746

Merged
merged 3 commits into from
Jul 6, 2022
Merged

Add more music icons and another mic icon #746

merged 3 commits into from
Jul 6, 2022

Conversation

it-is-not
Copy link
Contributor

music and mic icon

ericfennis
ericfennis approved these changes Jul 5, 2022
View reviewed changes
Copy link
Member

@ericfennis ericfennis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@it-is-not Nice icons!

karsa-mistmere
karsa-mistmere reviewed Jul 5, 2022
View reviewed changes
icons/music-2.svg Outdated Show resolved Hide resolved
karsa-mistmere
karsa-mistmere reviewed Jul 5, 2022
View reviewed changes
icons/mic-2.svg Outdated Show resolved Hide resolved
@karsa-mistmere karsa-mistmere merged commit 57cba6a into lucide-icons:master Jul 6, 2022
karsa-mistmere added a commit that referenced this pull request Jul 6, 2022
@karsa-mistmere
Revert "Add more music icons and another mic icon (#746)"
adf09a4 
This reverts commit 57cba6a.
karsa-mistmere added a commit that referenced this pull request Jul 6, 2022
@karsa-mistmere @it-is-not
Revert 746 master (#749)
46a30e0 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)"

This reverts commit 57cba6a.

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
karsa-mistmere added a commit that referenced this pull request Jul 6, 2022
@karsa-mistmere
Revert "Add more music icons and another mic icon (#746)"
db8e846 
This reverts commit 57cba6a.
karsa-mistmere added a commit that referenced this pull request Jul 6, 2022
@karsa-mistmere
Revert "Add more music icons and another mic icon (#746)" (#750)
cfbe736 
This reverts commit 57cba6a.
@karsa-mistmere
Copy link
Member

karsa-mistmere commented Jul 6, 2022 •
edited
Loading

@it-is-not: Hey, I've just noticed that you opened this PR to merge into master, but we've switched to main recently, could you open a new PR so that I can merge that and you still get properly credited?

main...it-is-not:lucide:master

@it-is-not it-is-not mentioned this pull request Jul 6, 2022
Merged
ericfennis pushed a commit that referenced this pull request Nov 21, 2022
@it-is-not @karsa-mistmere
Add subtitles icon (#890)
dd5a5b1 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* add subtitles icon

Co-authored-by: Karsa <contact@karsa.org>
ericfennis pushed a commit that referenced this pull request Mar 1, 2023
@karsa-mistmere @it-is-not
Adds tower-control icon (#963)
de2e303 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds tower-control icon

* Update icons/tower-control.json

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
ericfennis pushed a commit that referenced this pull request Mar 2, 2023
@karsa-mistmere @it-is-not
Adds pill & tablets icons (#969)
72c25a9 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds tablets & pill icons

* adds some extra tags

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
ericfennis pushed a commit that referenced this pull request Mar 4, 2023
@karsa-mistmere @it-is-not
Adds blinds icon (#970)
9a41d93 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds blinds icon

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
ericfennis pushed a commit that referenced this pull request Mar 10, 2023
@karsa-mistmere @it-is-not
Adds bird icon (#968)
244a5a3 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds bird icon

* Update icons/bird.svg

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
ericfennis pushed a commit that referenced this pull request Mar 19, 2023
@karsa-mistmere @it-is-not @jguddas
Adds brain (ai) icons (#967)
ee2bfaf 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds brain icons

* adds extra AI tags

* Update icons/brain-circuit.svg

Co-authored-by: Jakob Guddas <github@jguddas.de>

* Update brain.svg

* Update brain-circuit.svg

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
Co-authored-by: Jakob Guddas <github@jguddas.de>
ericfennis pushed a commit that referenced this pull request Mar 27, 2023
@karsa-mistmere @it-is-not
Adds plane-takeoff & plane-landing icons (#964)
f0fe196 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds plane-takeoff & plane-landing icons

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
ericfennis pushed a commit that referenced this pull request Apr 8, 2023
@karsa-mistmere @it-is-not
Adds receipt icon (#974)
408c683 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* adds receipt icon

* Update icons/receipt.svg

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <karsa@karsa.org>
ericfennis added a commit that referenced this pull request Apr 20, 2023
@ericfennis @it-is-not @karsa-mistmere
Introducing absoluteStrokeWidth option on Lucide Components (#939)
a87ae2a 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* add scale Stroke width

* Added scaleStrokeWidth prop to all packages

* Add scaleStrokeWidth to types

* Rename scaleStrokeWidth to absoluteStrokeWidth

* Adds common API elements to the Angular package (#949)

* Almost complete rewrite of the Angular package

* Update tsconfig.spec.json

* fixes icon build export file name

* Updates Angular documentation with the new properties + provider injection

* Update lucide-angular.md

* refactored scaleStrokeWidth to be absoluteStrokeWidth to match other packages

* removed codelyzer from devDeps + added flexible angular core dependencies

* Deprecates createElement helper in favour of Renderer2 to support SSR

---------

Co-authored-by: Karsa <karsa@karsa.org>

* Add absoluteStrokeWidth in docs

* update snapshots

* Manual merge of main

* Fixed incorrectly merged pnpm-lock.yaml

* Fixes lucide-angular build

* [lucide-angular] Global configuration for properties + bugfix for legacy icon provider   (#1012)

* Almost complete rewrite of the Angular package

* Update tsconfig.spec.json

* fixes icon build export file name

* Updates Angular documentation with the new properties + provider injection

* Update lucide-angular.md

* refactored scaleStrokeWidth to be absoluteStrokeWidth to match other packages

* removed codelyzer from devDeps + added flexible angular core dependencies

* Deprecates createElement helper in favour of Renderer2 to support SSR

* Added global configuration and fixed undefined bug in legacy icon provider. Also updated README.md

* Replaces removed line in README.md

* Fixes merge error

* Updates export template to use the non-deprecated type

* downgrade building to ng-cli@13

* downgrade to es2020

---------

Co-authored-by: Karsa <karsa@karsa.org>

* rename scaleStrokeWidth to absoluteStrokeWidth in readme

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <contact@karsa.org>
Co-authored-by: Eric Fennis <eric@dreamteam.nl>
Co-authored-by: Karsa <karsa@karsa.org>
Co-authored-by: Eric Fennis <eric.fennis@nac41112.nedap.local>
ericfennis pushed a commit that referenced this pull request Jun 6, 2023
@guillermo-angeles @it-is-not
@karsa-mistmere @jguddas
Add Goal icon (#1251)
e490bc3 
* Add more music icons and another mic icon (#746)

* Revert "Add more music icons and another mic icon (#746)" (#750)

This reverts commit 57cba6a.

* Add `goal` icon

* Update icons/goal.svg

Co-authored-by: Jakob Guddas <github@jguddas.de>

* Update icons/goal.svg

Co-authored-by: Karsa <contact@karsa.org>

---------

Co-authored-by: it-is-not <72697755+it-is-not@users.noreply.github.com>
Co-authored-by: Karsa <contact@karsa.org>
Co-authored-by: Guillermo Angeles <guillermo.angeles@adoptaunabuelo.com>
Co-authored-by: Guillermo Angeles <67046262+g-angeles-aua@users.noreply.github.com>
Co-authored-by: Jakob Guddas <github@jguddas.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karsa-mistmere karsa-mistmere karsa-mistmere left review comments

@ericfennis ericfennis ericfennis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@it-is-not @karsa-mistmere @ericfennis