small updates to match the paper's settings #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@shenberg hey Roee! thank you! i don't know the audio hyperparameters well enough hello from SF as well :) |
|
Wow that was peak fast-response! Thanks! |
|
from one great city to another! |
|
@shenberg @lucidrains I wouldn't recommend a hop size that isn't //2 or //4 though as this hurts perfect reconstruction abilities of the the stft window |
|
@faroit oh, so you would recommend 512? |
|
Yeah. That's much safer |
|
ok, let's roll with that! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Section 4.4 specifies "We apply a Hann window size of 2048 and a
hop size of 10 ms for STFT to compute the complex spectrogram..." and Section 4.1 says "All recordings are stereo with a sampling rate of 44.1k Hz" so I updated the constants accordingly