Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Red color on Stroke order #49

Closed
cyyeong opened this issue May 18, 2020 · 3 comments
Closed

Red color on Stroke order #49

cyyeong opened this issue May 18, 2020 · 3 comments

Comments

@cyyeong
Copy link

cyyeong commented May 18, 2020

Hi,
This is a wonderful generator.
Please change the color of the "Stroke order" to red or make it customizable. Currently it's hard to differentiate with black and white.
@lucivpav
Copy link
Owner

Hi there,
I'm glad you find it useful.
Can you make a PR, where user can choose between black (default), red and blue?

cyyeong pushed a commit to cyyeong/cwg that referenced this issue May 28, 2020
@anthony-yeong-dragon
lucivpav#49 Add color option for stroke order
adc5426
cyyeong pushed a commit to cyyeong/cwg that referenced this issue May 28, 2020
@anthony-yeong-dragon
lucivpav#49 Update readme
e4bb371
cyyeong pushed a commit to cyyeong/cwg that referenced this issue May 28, 2020
@anthony-yeong-dragon
lucivpav#49 Fix the stroke color argument
f5cdae9
@cyyeong
Copy link
Author

cyyeong commented May 28, 2020

Here you go:
#50

lucivpav pushed a commit that referenced this issue May 28, 2020
@anthony-yeong-dragon @lucivpav
#49 Add color option for stroke order
fb442cf
lucivpav pushed a commit that referenced this issue May 28, 2020
@anthony-yeong-dragon @lucivpav
#49 Update readme
523e946
lucivpav pushed a commit that referenced this issue May 28, 2020
@anthony-yeong-dragon @lucivpav
#49 Fix the stroke color argument
8387a9e
@lucivpav
Copy link
Owner

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucivpav @cyyeong