Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViaVersion Sponge incompatability #2822

Closed
Willsr71 opened this issue Jan 12, 2021 · 2 comments
Closed

ViaVersion Sponge incompatability #2822

Willsr71 opened this issue Jan 12, 2021 · 2 comments
Labels
type: issue The issue identifies a bug/problem with the software.

Comments

@Willsr71
Copy link

Willsr71 commented Jan 12, 2021

Description

ViaVersion seems to be incompatible with LuckPerms on Sponge. The error is here.
I've narrowed this down to this line in ViaFacet of the LuckPerms adventure platform. The issue appears to stem from LuckPerms loading the class before ViaVersion. The class loaded has a static declaration, and one of the methods called references it's own plugin. LuckPerms manages this just fine, however when ViaVersion ends up loading it promptly fails as a result. I believe this could be solved with using a different Class.forName method, however i'm not terribly familiar with Sponge classloading if they do anything weird or the LuckPerms adventure platform.

Reproduction steps

Use the latest builds of LuckPerms and ViaVersion together on a Sponge server (tested with SpongeVanilla, probably the same on SpongeForge).

Environment details

SpongeVanilla 1.12.2 API 7.3.0
LuckPerms Sponge 5.2.78 (5.2.76 and some in-between versions also tested)
ViaVersion 3.2.2 (or latest dev 3.3.0, back to 3.2.0 was tested a bit ago)

@Willsr71 Willsr71 added the type: issue The issue identifies a bug/problem with the software. label Jan 12, 2021
@lucko
Copy link
Member

lucko commented Jan 12, 2021

Thanks for the report - as you noted, this issue is actually coming from one of the libraries LP uses, adventure-platform.

Would you mind copying your report to the issue tracker here: https://github.com/KyoriPowered/adventure-platform/issues :)

@lucko
Copy link
Member

lucko commented Jan 18, 2021

Btw, I've added a workaround in LP for until this can be fixed in adventure. Try again using the latest version

@lucko lucko closed this as completed Jan 18, 2021
LeoDog896 pushed a commit to Project-Cepi/LuckPerms that referenced this issue Jan 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: issue The issue identifies a bug/problem with the software.
Projects
None yet
Development

No branches or pull requests

2 participants