Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedded docs link needs url #782

Closed
robacarp opened this issue Sep 30, 2022 · 2 comments · Fixed by #794
Closed

Embedded docs link needs url #782

robacarp opened this issue Sep 30, 2022 · 2 comments · Fixed by #794

Comments

@robacarp
Copy link
Contributor

# Used only in development when running `lucky watch`.
# Will reload browser whenever files change.
# See [docs]()
live_reload_connect_tag

@jwoertink
Copy link
Member

Related: luckyframework/website#1071

@robacarp
Copy link
Contributor Author

On second thought I'm not convinced that the docblock even needs to be there. The rest of the helper methods in that component aren't supported by documentation. Perhaps the "only in development" should be made more explicit by doing something like:

live_reload_connect_tag if Lucky::Env.development?

Or perhaps, alternatively, all of the method calls in that component should have a docblock that points to documentation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants