Skip to content

Commit

Permalink
memops: avoid using first_pseudo()
Browse files Browse the repository at this point in the history
The loop in rewrite_load_instruction() uses first_pseudo() to not have
to special case the first element.

But this slightly complicates further changes.

So, simply use a null-or-no-null test inside the loop to identify
this first element.

Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
  • Loading branch information
lucvoo committed Apr 17, 2021
1 parent 3de14a1 commit b91ba64
Showing 1 changed file with 5 additions and 3 deletions.
8 changes: 5 additions & 3 deletions memops.c
Original file line number Diff line number Diff line change
Expand Up @@ -19,15 +19,17 @@

static void rewrite_load_instruction(struct instruction *insn, struct pseudo_list *dominators)
{
pseudo_t new, phi;
pseudo_t new = NULL;
pseudo_t phi;

/*
* Check for somewhat common case of duplicate
* phi nodes.
*/
new = first_pseudo(dominators)->def->phi_src;
FOR_EACH_PTR(dominators, phi) {
if (new != phi->def->phi_src)
if (!new)
new = phi->def->phi_src;
else if (new != phi->def->phi_src)
goto complex_phi;
} END_FOR_EACH_PTR(phi);

Expand Down

0 comments on commit b91ba64

Please sign in to comment.