-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feedback commit #118
Open
case-eee
wants to merge
1
commit into
master
Choose a base branch
from
feedback
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feedback commit #118
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
ruby: | ||
config_file: .rubocop.yml |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--color | ||
--require spec_helper |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
Documentation: | ||
Enabled: false | ||
Style/FrozenStringLiteralComment: | ||
Enabled: false | ||
Style/StringLiterals: | ||
Enabled: false | ||
Style/VariableNumber: | ||
EnforcedStyle: snake_case | ||
Style/EmptyLinesAroundClassBody: | ||
Enabled: false | ||
Style/EmptyLinesAroundModuleBody: | ||
Enabled: false | ||
Style/SpaceInsideHashLiteralBraces: | ||
Enabled: false | ||
Style/BracesAroundHashParameters: | ||
Enabled: false | ||
|
||
Metrics/LineLength: | ||
Exclude: | ||
- 'spec/**/*' | ||
|
||
|
||
AllCops: | ||
Exclude: | ||
- 'db/**/*' | ||
- 'config/**/*' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
language: ruby | ||
rvm: | ||
- 2.3.0 | ||
services: | ||
- postgresql | ||
env: | ||
- TEST_DIRECTORY=spec/models | ||
- TEST_DIRECTORY=spec/features | ||
before_script: | ||
- psql -c 'create database travis_ci_test;' -U postgres | ||
script: | ||
- xvfb-run bundle exec rspec $TEST_DIRECTORY | ||
cache: bundler | ||
sudo: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,24 +1,11 @@ | ||
# README | ||
# Little Shop | ||
#### Master branch build status: ![](https://travis-ci.org/lucyconklin/little_shop.svg?branch=master) | ||
|
||
This README would normally document whatever steps are necessary to get the | ||
application up and running. | ||
1610 module 2 final group project | ||
* [Assignment Markdown](https://github.com/turingschool/curriculum/blob/master/source/projects/little_shop.markdown) | ||
* [Timber Shop on Heroku](https://timber-shop.herokuapp.com/) | ||
|
||
Things you may want to cover: | ||
|
||
* Ruby version | ||
|
||
* System dependencies | ||
|
||
* Configuration | ||
|
||
* Database creation | ||
|
||
* Database initialization | ||
|
||
* How to run the test suite | ||
|
||
* Services (job queues, cache servers, search engines, etc.) | ||
|
||
* Deployment instructions | ||
|
||
* ... | ||
@cpowell23 | ||
@ski-climb | ||
@lucyconklin | ||
@robbie-smith |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
$(function() { | ||
var $form = $('#payment-form'); | ||
$form.submit(function(event) { | ||
// Disable the submit button to prevent repeated clicks: | ||
$form.find('.submit').prop('disabled', true); | ||
|
||
// Request a token from Stripe: | ||
Stripe.card.createToken($form, stripeResponseHandler); | ||
|
||
// Prevent the form from being submitted: | ||
return false; | ||
}); | ||
}); | ||
|
||
function stripeResponseHandler(status, response) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. wooo stripe checkout 🎉 |
||
// Grab the form: | ||
var $form = $('#payment-form'); | ||
|
||
if (response.error) { // Problem! | ||
|
||
// Show the errors on the form: | ||
$form.find('.payment-errors').text(response.error.message); | ||
$form.find('.submit').prop('disabled', false); // Re-enable submission | ||
|
||
} else { // Token was created! | ||
|
||
// Get the token ID: | ||
var token = response.id; | ||
console.log(response); | ||
|
||
// Insert the token ID into the form so it gets submitted to the server: | ||
$form.append($('<input type="hidden" name="stripeToken">').val(token)); | ||
$form.append($('<input type="hidden" name="card_brand">').val(response.card.brand)); | ||
$form.append($('<input type="hidden" name="card_last4">').val(response.card.last4)); | ||
$form.append($('<input type="hidden" name="card_exp_month">').val(response.card.exp_month)); | ||
$form.append($('<input type="hidden" name="card_exp_year">').val(response.card.exp_year)); | ||
|
||
// Submit the form: | ||
$form.get(0).submit(); | ||
} | ||
}; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i suggest adding an overview of what this application does here and perhaps how to pull it down and get it working locally 👍