Add mypy to pre-commit
#1021
Merged
Add mypy to pre-commit
#1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
michplunkett
requested review from
b-meson,
abandoned-prototype,
null-space-0 and
redshiftzero
b-meson
approved these changes
Aug 12, 2023
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
This should be merged after this PR: lucyparsons#1020 lucyparsons#737 Since we have the `mypy.ini` file, I presume that we are intending on using `mypy`. To stay up to date, I am adding `mypy` to the `pre-commit` hook. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Sep 25, 2023
This should be merged after this PR: lucyparsons#1020 lucyparsons#737 Since we have the `mypy.ini` file, I presume that we are intending on using `mypy`. To stay up to date, I am adding `mypy` to the `pre-commit` hook. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
sea-kelp
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Oct 9, 2023
This should be merged after this PR: lucyparsons#1020 lucyparsons#737 Since we have the `mypy.ini` file, I presume that we are intending on using `mypy`. To stay up to date, I am adding `mypy` to the `pre-commit` hook. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
AetherUnbound
pushed a commit
to OrcaCollective/OpenOversight
that referenced
this pull request
Nov 11, 2023
This should be merged after this PR: lucyparsons#1020 lucyparsons#737 Since we have the `mypy.ini` file, I presume that we are intending on using `mypy`. To stay up to date, I am adding `mypy` to the `pre-commit` hook. - [x] This branch is up-to-date with the `develop` branch. - [x] `pytest` passes on my local development environment. - [x] `pre-commit` passes on my local development environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
This should be merged after this PR: #1020
Fixes issue
#737
Description of Changes
Since we have the
mypy.inifile, I presume that we are intending on usingmypy. To stay up to date, I am addingmypyto thepre-commithook.Tests and linting
developbranch.pytestpasses on my local development environment.pre-commitpasses on my local development environment.