Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

print: :silent #2

Closed
NobbZ opened this issue Mar 16, 2016 · 8 comments
Closed

print: :silent #2

NobbZ opened this issue Mar 16, 2016 · 8 comments

Comments

@NobbZ
Copy link

NobbZ commented Mar 16, 2016

It would be nice if we had a print: :silent configuration option, such that nothing at all is printed when compiling in prod environment.

@niahoo
Copy link
Collaborator

niahoo commented Mar 17, 2016

Good idea :) Will do.

@niahoo
Copy link
Collaborator

niahoo commented Mar 17, 2016

At the moment, :all has precedence over :overdue and :overdue is the default value.

So I think :silent should take precendence over :overdue but let :all as the higher precedence.

@NobbZ
Copy link
Author

NobbZ commented Mar 17, 2016

I don't like this priority thing very well.

I do think it where better to have priorities more like module-config > global-config. That seems more natural and is similar to other libraries.

@niahoo
Copy link
Collaborator

niahoo commented Mar 17, 2016

I agree, but I need a way to print all the todos for a project, even if some modules are configured with :overdue explicitly.

So it could be global-config == :force_all > module-config > global-config.

@NobbZ
Copy link
Author

NobbZ commented Mar 17, 2016

Or you could introduce flags to the mix-task, mix todo --all, (or --silent, or --overdue) which does overrule anything specified at module or config level.

Of course it does not make that much sense to implement also flags for the persist config ;)

@niahoo
Copy link
Collaborator

niahoo commented Mar 17, 2016

Yeah I'm tinkering with flags right at the moment ; got the same idea a couple minutes ago ;)

So I will just let the module config take precedence over the global config and implement flags.

As for the persist configuration we do not care, I can let the module config take precedence too.

niahoo pushed a commit that referenced this issue Mar 17, 2016
@niahoo
Copy link
Collaborator

niahoo commented Mar 17, 2016

So I revamped the whole thing with flags and simple config logic. This is nice.

@niahoo
Copy link
Collaborator

niahoo commented Mar 18, 2016

Feel free to reopen if you try this and have some problem.

@niahoo niahoo closed this as completed Mar 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants