Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scandir option #28

Merged
merged 3 commits into from
Oct 3, 2020
Merged

Add scandir option #28

merged 3 commits into from
Oct 3, 2020

Conversation

dadav
Copy link
Contributor

@dadav dadav commented Oct 1, 2020

This implements the suggestion #26. With this it's possible to limit the checking on a certain directory instead of the whole project.

Closes #26

Copy link
Owner

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @dadav 🎉
This looks good, but can you add . to INPUT_SCANDIR if INPUT_SCANDIR is not defined at the top of runaction?

@dadav
Copy link
Contributor Author

dadav commented Oct 2, 2020

Do you think this https://github.com/dadav/action-shellcheck/blob/master/action.yaml#L20 isn't enough?

@ludeeus
Copy link
Owner

ludeeus commented Oct 3, 2020

Nope, that makes it dependant on GitHub not changing things without notice (which has happened in the past)

Copy link
Owner

@ludeeus ludeeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

@ludeeus ludeeus merged commit fcee962 into ludeeus:master Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to only scan a certain directory
2 participants