Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The self.reshape_features is empty when working on petfinder dataset #1135

Closed
zhisbug opened this issue Mar 28, 2021 · 3 comments
Closed

The self.reshape_features is empty when working on petfinder dataset #1135

zhisbug opened this issue Mar 28, 2021 · 3 comments
Labels
waiting for answer Further information is requested

Comments

@zhisbug
Copy link
Contributor

zhisbug commented Mar 28, 2021

Describe the bug
This issue is related with #1134.

I tried to replace the reshape_features with features to workaround the bug caused by IteratableBatcher (see #1134 for the detailed descriptions about the issue), but when working on the petfinder dataset, the self.reshapes_features is empty after applying the following code between L35-L39 of parquet.py:

self.reshape_features = {
    feature[PROC_COLUMN]: list((-1, *training_set_metadata[feature[NAME]]['reshape']))
    for feature in features
    if 'reshape' in training_set_metadata[feature[NAME]]
}

To Reproduce
Use my experiment script on petfinder dataset here: https://github.com/zhisbug/ludwig-petfinder/blob/master/petfinder-adoption-prediction/train.py

Try to print self.reshaped_features and you will see it is an empty dict.

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: [e.g. iOS]
  • Version [e.g. 22]
  • Python version
  • Ludwig version

Additional context
Add any other context about the problem here.

@zhisbug
Copy link
Contributor Author

zhisbug commented Mar 28, 2021

See PR#1136 my workaround on this

@tgaddair
Copy link
Collaborator

Hey @zhisbug, are you running with image features? If not, then it's expected that rehshape_features should be empty (as there are no features that need to be reshaped when loaded from the Parquet file). Is this still an issue after applying #1138?

@tgaddair tgaddair added the waiting for answer Further information is requested label Mar 29, 2021
@zhisbug
Copy link
Contributor Author

zhisbug commented Apr 1, 2021

Yes!

@zhisbug zhisbug closed this as completed Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting for answer Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants