Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed IterableBatcher incompatibility with ParquetDataset and remote model serialization #1138

Merged
merged 8 commits into from
Apr 2, 2021

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Mar 29, 2021

Fixes #1134.

Also attempts to address #1137.

@tgaddair
Copy link
Collaborator Author

Pinned Dask version to workaround ray-project/ray#14992.

@zhisbug
Copy link
Contributor

zhisbug commented Mar 31, 2021

Hi @tgaddair ,

Thanks! I just tested -- it fixes #1134 but not #1137 .

When I disabled the image model branch I still observed the same error when calling model.set_weights; when I enable the image branch everything works fine. So I guess it is related with the application?

@tgaddair
Copy link
Collaborator Author

tgaddair commented Apr 1, 2021

Hmm, that's a bummer. Let me pull your branch and try and repro today.

@tgaddair
Copy link
Collaborator Author

tgaddair commented Apr 2, 2021

@zhisbug I'll go ahead and merge this for now since it fixes some tests that were failing on master. We'll leave #1137 open for now.

@tgaddair tgaddair merged commit 47c1de8 into master Apr 2, 2021
@tgaddair tgaddair deleted the fixed-ray branch April 2, 2021 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parquet dataset does not have a self.features attribute, which is needed in the IterableBatcher
2 participants