Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstracted Horovod params into the Backend API #1080

Merged
merged 105 commits into from
Feb 1, 2021
Merged

Conversation

tgaddair
Copy link
Collaborator

@tgaddair tgaddair commented Jan 17, 2021

This PR is a precursor to adding a the Ray and Dask backends.

@tgaddair tgaddair changed the title Abstracted Horovod into Backend to support multiple distributed trainers Abstracted Horovod params into the Backend API Jan 17, 2021
ludwig/collect.py Show resolved Hide resolved
ludwig/evaluate.py Show resolved Hide resolved
ludwig/experiment.py Show resolved Hide resolved
ludwig/features/category_feature.py Show resolved Hide resolved
ludwig/hyperopt_cli.py Show resolved Hide resolved
ludwig/models/trainer.py Show resolved Hide resolved
ludwig/predict.py Show resolved Hide resolved
ludwig/preprocess.py Show resolved Hide resolved
ludwig/train.py Show resolved Hide resolved
requirements.txt Outdated
@@ -12,6 +12,7 @@ PyYAML>=3.12
absl-py
kaggle
requests
tables
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this required?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually needed for the Dask PR, if I remember correctly, so I'll remove this for now and add it in that PR.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a huge deal, but moving it will likely keep things cleaner

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@w4nderlust w4nderlust merged commit c924423 into master Feb 1, 2021
@w4nderlust w4nderlust deleted the backend_refactor branch February 1, 2021 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants