Refactored all contrib classes to use the Callback interface #1187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsblank would you mind giving feedback on this? It changes the architecture a bit wrt how we implemented the contrib back then, but it shouldn't change the functionality. |
tgaddair
force-pushed
the
contrib_refactor
branch
from
67dd0cb
to
bdad471
Compare
w4nderlust
approved these changes
Jun 3, 2021
|
@dsblank we are moving forward and merging, let me know if you have opinions, suggestions or concerns though |
|
Thanks! We'll be actively looking at this over the few days. Much appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change replaces all global contrib handlers with callbacks, removing the handler instances from global state and aligning the API with hyperopt callbacks.