Non-absolute image path support #1224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
w4nderlust
reviewed
Jul 12, 2021
| sample_images = [ImageFeatureMixin.read_image( | ||
| ImageFeatureMixin.get_image_from_path(src_path, img)) for img in input_feature_col[:sample_size]] | ||
|
|
||
| height_avg = min( |
There was a problem hiding this comment.
The ImageFeatureMixin.MIN_IMAGE_INFER_DIM should be MAX not MIN, as we want to make sure the inferred image size is not above a certain amount.
Also, having a default ImageFeatureMixin.MAX_IMAGE_INFER_DIM = 256 is ok, but maybe that could be a preprocessing parameter too.
|
On more thing that would be great is to have a test for remote images (you could use the images in the Ludwig readme for this purpose) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code Pull Requests
Please provide the following:
min(avg([width | height]), 256)sampling the first 100 images. Checking the sizes of all images seems rather complicated and involves format-specific logic that may break if header data is malformed.is_httpcheck passes the url directly toimreadbecausefsspeccan error trying to retrieve image info, which may be related to the jpeg/header issue above.