Removed DaskBackend and moved tests to RayBackend #1412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DaskBackend only works because of Petastorm and TFRecord as intermediate storage formats. However, these are planned to be removed in place of RayDatasets, which has been shown to outperform these other formats in our benchmarks.
Additionally, the DaskBackend did not support distributed training (only distributed preprocessing) making its utility rather limited. I think it would be worth revisiting this backend in the future if there is a compelling use case from users, but for now it's better to only support that which is well tested and proven effective.