Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pretrained_kwargs to BertEncoder #1699

Merged
merged 2 commits into from
Jan 25, 2022
Merged

Conversation

connor-mccorm
Copy link
Contributor

Added pretrained_kwargs constructor variable. Then added same variable to .from_pretrained() which will capture kwargs if present.

@github-actions
Copy link

github-actions bot commented Jan 21, 2022

Unit Test Results

       8 files  ±0         8 suites  ±0   1h 29m 31s ⏱️ + 1m 6s
2 170 tests +1  2 139 ✔️ ±0    30 💤 ±0  1 +1 
8 680 runs  +4  8 559 ✔️ +3  120 💤 ±0  1 +1 

For more details on these failures, see this check.

Results for commit 85676a4. ± Comparison against base commit 68b0f1c.

♻️ This comment has been updated with latest results.

@tgaddair tgaddair linked an issue Jan 22, 2022 that may be closed by this pull request
@tgaddair
Copy link
Collaborator

Thanks @connor-mccorm, can you add this to all the huggingface text encoders?

@connor-mccorm
Copy link
Contributor Author

Absolutely @tgaddair, I’ll get right on it!

@justinxzhao justinxzhao merged commit 78bc0b4 into master Jan 25, 2022
@connor-mccorm connor-mccorm deleted the cache_dir_feature branch January 25, 2022 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specify the cache_dir for huggingface transformer models
3 participants