Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move marshmallow schemas into single schema module. #1964

Closed
wants to merge 26 commits into from
Closed

Move marshmallow schemas into single schema module. #1964

wants to merge 26 commits into from

Conversation

ksbrar
Copy link
Collaborator

@ksbrar ksbrar commented Apr 26, 2022

Proof of concept (do not merge).

ksbrar and others added 23 commits April 23, 2022 22:07
@ksbrar
Remove generated files.
b7ce8c4
@ksbrar
Remove extraction script.
6424655
@ksbrar
Adjust marshmallow_schema_utils.
74a4d32
@ksbrar
change manifest.
3e166d4
@ksbrar
adjust combiners, rename unload method.
bfb2e61
@ksbrar
adjust trainer
5ee4eca
@ksbrar
convert optimizers.
664b4c7
@ksbrar
update FloatRange allow_none
765c783
@ksbrar
Add descriptions to optimizer, gradientclipping dataclass fields.
11a2857
@ksbrar
update marshmallow tests.
4e8a232
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
2e57cb2 
for more information, see https://pre-commit.ci
@ksbrar
fix
b266763
@ksbrar
Merge branch 'refactor_remove_marshmallow_extraction' of github.com:k…
39dfdc0 
…sbrar/ludwig into refactor_remove_marshmallow_extraction
@ksbrar
remove old method refs.
f7601e7
@ksbrar
fix
f3df813
@ksbrar
replace default description None with TODO
a3406f4
@ksbrar
fix test
a927865
@ksbrar
additionalProperties fix
1affa5b
@ksbrar
Rename marshamllow_schema_utils file -> utils
7742720
@ksbrar
rename ludwig.marshmallow folder -> ludwig.schema
d8863b1
@ksbrar
Move ludwig/utils/schema file to new ludwig/schema folder.
26008fd
@ksbrar
style: clean up some import aliases.
b3e93dd
@ksbrar
split up combiners.
bfe1b0a
@ksbrar ksbrar added the productivity and code quality Engineer productivity, maintainability, consistency, readability label Apr 26, 2022
@github-actions
Copy link

github-actions bot commented Apr 26, 2022 •
edited
Loading

Unit Test Results

0 files   -        6  0 suites   - 6   0s ⏱️ - 1h 22m 28s
0 tests  - 2 762  0 ✔️  - 2 731  0 💤  - 31  0 ❌ ±0 
0 runs   - 8 286  0 ✔️  - 8 188  0 💤  - 98  0 ❌ ±0 

Results for commit a3ff9a6. ± Comparison against base commit a4ce839.

♻️ This comment has been updated with latest results.

@ksbrar
Copy link
Collaborator Author

ksbrar commented Apr 27, 2022

Mostly subsumed by #1963

@ksbrar ksbrar closed this Apr 27, 2022
@ksbrar ksbrar deleted the move_all_schemas_into_single_module branch April 27, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w4nderlust w4nderlust Awaiting requested review from w4nderlust w4nderlust will be requested when the pull request is marked ready for review w4nderlust is a code owner

@tgaddair tgaddair Awaiting requested review from tgaddair tgaddair will be requested when the pull request is marked ready for review tgaddair is a code owner

@justinxzhao justinxzhao Awaiting requested review from justinxzhao justinxzhao will be requested when the pull request is marked ready for review justinxzhao is a code owner

@arnavgarg1 arnavgarg1 Awaiting requested review from arnavgarg1 arnavgarg1 will be requested when the pull request is marked ready for review arnavgarg1 is a code owner

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus will be requested when the pull request is marked ready for review geoffreyangus is a code owner

@jeffkinnison jeffkinnison Awaiting requested review from jeffkinnison jeffkinnison will be requested when the pull request is marked ready for review jeffkinnison is a code owner

@Infernaught Infernaught Awaiting requested review from Infernaught Infernaught will be requested when the pull request is marked ready for review Infernaught is a code owner

@alexsherstinsky alexsherstinsky Awaiting requested review from alexsherstinsky alexsherstinsky will be requested when the pull request is marked ready for review alexsherstinsky is a code owner

Assignees
No one assigned
Labels
productivity and code quality Engineer productivity, maintainability, consistency, readability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ksbrar