Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SIGINT handler to modify the number of remaining training steps. #2032

Merged
merged 2 commits into from
May 15, 2022

Conversation

justinxzhao
Copy link
Contributor

@justinxzhao justinxzhao commented May 13, 2022

  • First SIGINT will try to finish training at the very next training step.
  • Another SIGINT will stop training abruptly.

Also, removes quit_training -- this is no longer called anywhere.

@github-actions
Copy link

github-actions bot commented May 13, 2022

Unit Test Results

       6 files  ±  0         6 suites  ±0   1h 43m 16s ⏱️ + 12m 1s
2 785 tests +  9  2 750 ✔️ +  9    35 💤 ±0  0 ±0 
8 355 runs  +27  8 245 ✔️ +27  110 💤 ±0  0 ±0 

Results for commit 3250897. ± Comparison against base commit c3e4abf.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@connor-mccorm connor-mccorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, only thing I would maybe add is possibly initializing self.total_steps in the constructor if were switching to using the class variable. WDYT?

@justinxzhao
Copy link
Contributor Author

Looks good to me, only thing I would maybe add is possibly initializing self.total_steps in the constructor if were switching to using the class variable. WDYT?

Good idea. Done!

@justinxzhao justinxzhao merged commit d47d857 into master May 15, 2022
@justinxzhao justinxzhao deleted the sigint branch May 15, 2022 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants