fix: Adjust custom JSON schema for betas field on optimizers
#2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small change, necessary for proper UI rendering. Implication of the change is that array fields (like `betas` or anything that may use `FloatRangeTupleDataclassField` in the future) are validated [Draft-4 spec](https://json-schema.org/understanding-json-schema/reference/array.html#id7)-style.
justinxzhao
approved these changes
May 25, 2022
tgaddair
approved these changes
May 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small change, necessary for proper UI rendering. The other implication of this change is that array fields (like
betasor anything that may useFloatRangeTupleDataclassFieldin the future) must be validated Draft-4 spec-style for now.