Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'bias' to 'use_bias' for consistency #2104

Merged
merged 3 commits into from
Jun 8, 2022

Conversation

dantreiman
Copy link
Contributor

Changes:
bias -> use_bias
default_bias -> default_use_bias
conv_bias -> conv_use_bias

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add deprecation and upgrade for these params here:

def _upgrade_deprecated_fields(config: Dict[str, Any]):

@github-actions
Copy link

github-actions bot commented Jun 7, 2022

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 30m 12s ⏱️ + 7m 32s
2 805 tests ±0  2 773 ✔️ ±0    32 💤 ±0  0 ±0 
8 415 runs  ±0  8 315 ✔️ ±0  100 💤 ±0  0 ±0 

Results for commit 62daed7. ± Comparison against base commit 5044239.

♻️ This comment has been updated with latest results.

@dantreiman
Copy link
Contributor Author

Please also add deprecation and upgrade for these params here:

def _upgrade_deprecated_fields(config: Dict[str, Any]):

Added. Also factored out compatibility code into its own module: backward_compatibility.py

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@dantreiman dantreiman merged commit 6ca6607 into ludwig-ai:master Jun 8, 2022
@dantreiman dantreiman deleted the daniel/rename_bias branch June 8, 2022 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants