-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration section for global feature parameters #2208
Add configuration section for global feature parameters #2208
Conversation
…0-rfc-add-configuration-section-for-global-feature-parameters
…arameters' of https://github.com/ludwig-ai/ludwig into 2130-rfc-add-configuration-section-for-global-feature-parameters
tests/ludwig/utils/test_defaults.py
Outdated
@@ -58,6 +63,21 @@ | |||
SCHEDULER_DICT = {"type": "async_hyperband", "time_attr": "time_total_s"} | |||
|
|||
|
|||
def _merge_preprocessing( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we delete/update the merge_preprocessing
function in preprocessing.py
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@justinxzhao I don't think that's necessary because https://github.com/ludwig-ai/ludwig/pull/2208/files#diff-671042bc7390c5a898a22f285e44a717dc6276bc0fd3e81142e8fc468e2e6e23R35 function does the work to pass in the data just like how it was being done before, which I also think is the cleanest way to do this.
This _merge_preprocessing
is unnecessary and I've updated the code with all that's needed for this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one comment, otherwise LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnavgarg1 could you also take a stab at updating the documentation for 0.6? https://ludwig-ai.github.io/ludwig-docs/0.5/configuration/
…h encoder/decoder default params
@justinxzhao One thing I noticed from Connor's PR is that he's updated the tests to reflect the new nesting of encoders and decoders. Right now everything works because of backward compatibility, but should I create a follow up PR that modifies the tests to use the updated Ludwig config with defaults? |
Talked to @justinxzhao - will create a follow up PR with modified tests. Closing this issue for now. |
This PR enables users to specify type-specific default preprocessing, encoder, decoder and loss related parameters by introducing a new top-level config section called
defaults
.In particular, this PR:
preprocessing
section such that the preprocessing section is only for things like splitting, etc.Example: