Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit handling for zero-length image byte buffers to avoid cryptic errors #2210

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Add explicit handling for zero-length image byte buffers to avoid cryptic errors #2210

merged 1 commit into from
Jun 30, 2022

Conversation

jeffreyftang
Copy link
Collaborator

In practice these cryptic errors may look like Existing exports of data: object cannot be re-sized.

@github-actions
Copy link

Unit Test Results

       5 files  ±0         5 suites  ±0   2h 14m 53s ⏱️ + 14m 42s
2 908 tests ±0  2 862 ✔️ ±0    46 💤 ±0  0 ❌ ±0 
8 556 runs  ±0  8 437 ✔️ ±0  119 💤 ±0  0 ❌ ±0 

Results for commit 9fafd4e. ± Comparison against base commit 236cf54.

geoffreyangus
geoffreyangus approved these changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@geoffreyangus geoffreyangus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@jeffreyftang jeffreyftang merged commit 9d7da5f into master Jun 30, 2022
@jeffreyftang jeffreyftang deleted the imagereaderr branch June 30, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreyangus geoffreyangus geoffreyangus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeffreyftang @geoffreyangus