Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support passing ground_truth as df for visualizations #2281

Merged
merged 5 commits into from
Jul 18, 2022
Merged

Support passing ground_truth as df for visualizations #2281

merged 5 commits into from
Jul 18, 2022

Conversation

hungcs
Copy link
Contributor

@hungcs hungcs commented Jul 14, 2022

No description provided.

@hungcs hungcs force-pushed the ext branch 2 times, most recently from aa691a0 to 544993f Compare July 14, 2022 21:34
justinxzhao
justinxzhao reviewed Jul 18, 2022
View reviewed changes
Copy link
Contributor

@justinxzhao justinxzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, just one comment and a couple of nits.

ludwig/visualize.py Outdated Show resolved Hide resolved
ludwig/visualize.py Outdated Show resolved Hide resolved
ludwig/visualize.py Outdated Show resolved Hide resolved
@hungcs hungcs requested a review from justinxzhao July 18, 2022 19:20
@github-actions
Copy link

Unit Test Results

       6 files  ±0         6 suites  ±0   2h 22m 56s ⏱️ - 9m 5s
2 936 tests +1  2 886 ✔️ ±0    49 💤 ±0  1 ❌ +1 
8 808 runs  +3  8 624 ✔️ +2  183 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 9661149. ± Comparison against base commit 640821a.

@hungcs hungcs merged commit c646a45 into master Jul 18, 2022
@hungcs hungcs deleted the ext branch July 18, 2022 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinxzhao justinxzhao justinxzhao approved these changes

@geoffreyangus geoffreyangus Awaiting requested review from geoffreyangus geoffreyangus is a code owner

@ShreyaR ShreyaR Awaiting requested review from ShreyaR

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hungcs @justinxzhao