Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand vision models to support pre-trained models #2408

Merged
merged 292 commits into from
Jan 11, 2023
Merged

Conversation

jimthompson5802
Copy link
Collaborator

Code Pull Requests

Adding support for using pre-trained models such as ResNet, VGG, EfficiientNet, etc.

@github-actions
Copy link

github-actions bot commented Aug 21, 2022

Unit Test Results

         6 files  ±    0           6 suites  ±0   4h 32m 24s ⏱️ + 13m 21s
  3 868 tests +292    3 794 ✔️ +291    74 💤 +2  0  - 1 
11 604 runs  +943  11 382 ✔️ +942  222 💤 +2  0  - 1 

Results for commit 0cd594d. ± Comparison against base commit 25135fe.

♻️ This comment has been updated with latest results.

pre-commit-ci bot and others added 29 commits September 7, 2022 01:10
Set use of pretrained weights to true
Always remove final classification layer
Add decorator to register torchvision model variant
…on-models

# Conflicts:
#	ludwig/utils/image_utils.py
# Conflicts:
#	ludwig/encoders/image_encoders.py
#	tests/ludwig/encoders/test_image_encoders.py
jimthompson5802 and others added 2 commits December 22, 2022 11:56
# Conflicts:
#	ludwig/encoders/image_encoders.py
#	ludwig/schema/encoders/image_encoders.py
Copy link
Contributor

@dantreiman dantreiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@tgaddair tgaddair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Follow-ups for us:

  • Backwards compatibility layer
  • Add back in tests
  • Re-organize encoders files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants