Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add comment about batch size tuning #3526

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Add comment about batch size tuning #3526

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions ludwig/trainers/trainer_llm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,6 +205,9 @@ def tune_batch_size(
snapshot_weights: bool = True,
on_best_batch_size_updated: Optional[Callable[[int, float, int], None]] = None,
) -> int:
# TODO: Implement batch size tuning for LLM, currently just returns the default batch size
# Compared to ECD, this just requires forward passes till we OOM.
# https://github.com/ludwig-ai/ludwig/issues/3525
return MINIMUM_BATCH_SIZE

@property
Expand Down
Loading