various improvement #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
lugu
commented
Dec 1, 2019
lugu
commented
- Client handle the "cancelled" response type.
- Do not register to a signal twice from a socket (fix double signal bug)
- IDL generation: fix name collision issue preventing naov6 IDL generation
- Re-enable statistics and trace testing
One cannot call RegisterEvent on the same signal twice without receiving undistinguishable events. This lead to a situation where signals events are received twice. Since clients share the same socket this became a problem. In order to avoid such situation, one need a state machine at the socket level: this change introduce a subscription abstraction linked to the client. It also makes the session re-use clients in order to ensure a single subscription is used per socket.
Register interface name when generating interfaces to avoid collision with a struct. NAOv6 IDL have both a service called knowledge and a struct called knowledge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.