Use electron-prebuilt for a cross-platform npm start #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I'm a little busy this month for implementing #21, so a pull request for packaging is very welcome. Merged. Thank you for the patch! |
luin
added a commit
that referenced
this pull request
Mar 21, 2020
Use electron-prebuilt for a cross-platform npm start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, modifying only
package.json(+1 dep, 1 modified script), the project can be run on any Electron-compatible platform.I was going to start working on packaging but as #21 is on its way tell me if it's interesting or not.