Kinetica support #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are to support the Kinetica database. Kinetica is a SQL based data warehouse database that does not support transaction processing. In effect, there is no ability to commit or rollback.
The instructions in https://flywaydb.org/documentation/contribute/contributingDatabaseSupport were followed. In a nutshell a new package folder for Kinetica was created with the corresponding classes being extended as per the documentation. There were some variations where the documentation did not work. Instead, I followed the package IgniteLight for the Apache Ignite database, which is quite similar in syntax. Furthermore, ExecutionTemplate had to be re-implemented into KineticaExecutionTemplate (i.e., override TransactionExecutionTemplate). Then KineticaExecutionTemplate is being used by KinetiaDatabaseType and overrides the method createTransactionalExecutionTemplate that is found in DatabaseType. The reason for doing this is that TransactionExcutionTemplate tries to commit and rollback transactions and these actions do not exist in Kinetica so that action had overridden.
Lastly, according to the documentation, the plugin is supposed to be added through
DatabaseTypeRegister.registerForDatabaseTypes add a registeredDatabaseTypes.add(new FooDatabaseType(classLoader)); line.
No such method was found anywhere. However, adding the package in src/main/resources/META-INF/services/org.flywaydb.core.extensibility.Plugin was all that was needed for the package to be registered and to make it work properly.