Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTPS (FTP over SSL) support #30

Closed
MinimalDigital opened this issue Feb 11, 2016 · 18 comments
Closed

FTPS (FTP over SSL) support #30

MinimalDigital opened this issue Feb 11, 2016 · 18 comments
Milestone

Comments

@MinimalDigital
Copy link

Are there any plans to support FTPS (FTP over SSL) connections?

@lukasz-wronski
Copy link
Owner

It should support FTPS already.. isn't it?

@MinimalDigital
Copy link
Author

Ah that's great if it does. I hadn't seen any reference to FTPS (FTP over SSL) in the readme, version history or GitHub issues. Only SFTP (Secure File Transfer Protocol) seems to be mentioned (and supported). I don't have the ability to test it myself just yet so I thought I'd ask the question.

Also thanks for the quick response!

@lukasz-wronski
Copy link
Owner

AFAIK the library I use for FTP supports FTPS without any problems as this
is the same protocol in terms of communication... Can anyone confirm it
works fine?

@KooiRUG
Copy link

KooiRUG commented Feb 13, 2016

Ftps doesn't work here, sorry.

@lukasz-wronski
Copy link
Owner

@KooiRUG, can you show me your config (without sensitive data)?

@KooiRUG
Copy link

KooiRUG commented Feb 14, 2016

@lukasz-wronski yep, here it is:

{
    "remotePath": "/my/path",
    "host": "nicon.nl",
    "protocol": "ftp",
    "port": 21,
    "secure": true,
    "password": "****",
    "username": "****", 
    "uploadOnSave": true,
    "passive": true,
    "debug": false,
    "ignore": [
        "\\.vscode",
        "\\.git"
    ]
}

And this is how it shows up in my ftp-server:

(000143)2/14/2016 16:04:11 PM - (not logged in) ([ip])> 220----------------------------------------------------------
(000143)2/14/2016 16:04:11 PM - (not logged in) ([ip])> 220- This is NICons FTP-server. We only allow sftp/ftps
(000143)2/14/2016 16:04:11 PM - (not logged in) ([ip])> 220 ---------------------------------------------------------
(000143)2/14/2016 16:04:11 PM - (not logged in) ([ip])> USER ****
(000143)2/14/2016 16:04:11 PM - (not logged in) ([ip])> 530 This server does not allow plain FTP. You have to use FTP over TLS.
(000143)2/14/2016 16:04:11 PM - (not logged in) ([ip])> disconnected.

In other words, no tls-attempt is made (no AUTH TLS command is sent).
But then again, may be my config is all wrong?

@lukasz-wronski
Copy link
Owner

@KooiRUG: Is this a correct port for FTPS connection? Shouldn't you use port 990?

@KooiRUG
Copy link

KooiRUG commented Feb 14, 2016

@lukasz-wronski Port 21 will do (explicit over SSL/TLS shares its port with the regular ftp-port), port 990 is for an implicit connection. Tried that too, but using port 990, we're not going beyond:

(000158)2/14/2016 17:38:47 PM - (not logged in) ([ip])> Connected on port 990, sending welcome message...

To be sure implicit connections work @ my server, I connected using another application:

(000159)2/14/2016 17:40:58 PM - (not logged in) ([ip])> Connected on port 990, sending welcome message...
(000159)2/14/2016 17:41:04 PM - (not logged in) ([ip])> SSL connection established
(000159)2/14/2016 17:41:06 PM - (not logged in) ([ip])> USER ****
(000159)2/14/2016 17:41:06 PM - (not logged in) ([ip])> 331 Password required for ****
(000159)2/14/2016 17:41:07 PM - (not logged in) ([ip])> PASS ****
(000159)2/14/2016 17:41:07 PM - **** ([ip])> 230 Logged on

@AdrienCasagrande
Copy link

In modules/ftp-config.js .getSyncConfig doesn't return any 'secure' option. So node-ftp always use the default false value.

getSyncConfig: function() {
        var config = this.getConfig();
        return {
            local: config.localPath,
            remote: upath.toUnix(config.remotePath),
            host: config.host,
            port: config.port,
            user: config.username,
            password: config.password,
            **secure: config.secure,**
            ignore: config.ignore,
            passive: config.passive,
            protocol: config.protocol || "ftp",
            privateKeyPath: config.privateKeyPath,
            debug: config.debug ? function(msg) {
                output(msg);
            } : null
        }

@devmount
Copy link

Is there any solution? My provider only allows FTP over TLS...

@Feday
Copy link

Feday commented Apr 20, 2016

Hello there, I also confirm that cannot use FTP over SSL

@hajekj
Copy link
Collaborator

hajekj commented May 30, 2016

Hey guys, created a pull request in order to enable the support (successfully tested it also).

@MinimalDigital
Copy link
Author

Is there any chance of this being added to the next release?

@bholmes451
Copy link

I'm interested in using this also. I have been using Filezilla but attempting to streamline my dev process currently and I liked this ftp plugin for vscode better than the other one :-)

@michalhudecek
Copy link

Any progress on this? We are forced to use FTPS on our server.

@hajekj
Copy link
Collaborator

hajekj commented Oct 22, 2016

This is now resolved and #62 is merged into master.

@FahadAli-Khan
Copy link

"port": 21,
"secure": true,
"protocol": "ftpes",
"secureOptions": {"rejectUnauthorized": false},
This works fine for me

@hajekj hajekj removed their assignment Jun 27, 2022
@cfmx
Copy link

cfmx commented Jul 18, 2022

"port": 21, "secure": true, "protocol": "ftpes", "secureOptions": {"rejectUnauthorized": false}, This works fine for me

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests