Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please create a tag for Coq 8.16 in Coq Platform 2022.09 #143

Closed
MSoegtropIMC opened this issue Aug 10, 2022 · 7 comments
Closed

Please create a tag for Coq 8.16 in Coq Platform 2022.09 #143

MSoegtropIMC opened this issue Aug 10, 2022 · 7 comments
Assignees

Comments

@MSoegtropIMC
Copy link

The Coq team released Coq 8.16+rc1 on June 01, 2022.
The corresponding Coq Platform release 2022.09 should be released before September 15, 2022.
It can be delayed in case of difficulties until October 15, 2022, but this should be an exception.

This issue is to inform you that to our (possibly a few days old) best knowledge the latest released version of your project (1.3.2+8.15) does not work with Coq 8.16+rc1.
We tried to remove version restrictions in opam files and possibly make or configure files, but this did not suffice.

Please note that in Coq Platform CI (unlike Coq CI) we test only released / tagged versions. Coq CI appears to test this project, but has some special handling for your project which makes it difficult to retrieve the commit it tests for your project.

Could you please create a tag and opam package, or communicate us any existing tag that works with Coq branch v8.16, preferably before August 31, 2022?
In case we might have to delay the Coq Platform release cause of issues with your project, we would prefer to be informed about the situation as early as possible.

In case the tag and opam package are available before August 17, 2022, it will be included in an early Coq Platform beta release of the for Coq 8.16+rc1.

The working branch of Coq Platform, can be found here main.
It contains package pick ~8.16+rc1~2022.09~preview1 which already supports Coq version 8.16+rc1 and contains already working (possibly patched / commit pinned) Coq Platform packages.

Please don't close this issue, even after creating the new tag and/or opam package.
We will close the issue after updating Coq Platform.
This is a measure of 'double book keeping' in order to avoid that we ship the wrong version.

In any case, Coq Platform won't be released before this issue is closed!

Thanks!

P.S.: this issue has been created automatically based on CI status.

CC: coq/platform#274

@lukaszcz lukaszcz self-assigned this Aug 10, 2022
@lukaszcz lukaszcz added help wanted Extra attention is needed and removed help wanted Extra attention is needed labels Aug 28, 2022
@lukaszcz
Copy link
Owner

lukaszcz commented Sep 4, 2022

The v1.3.2 release for Coq 8.16 has been created (branch v1.3.2-coq8.16)

@lukaszcz lukaszcz closed this as completed Sep 4, 2022
@SnarkBoojum
Copy link

Can I ask you to tag the same commit 09f5ffa as v1.3.2-coq8.16 in addition to the existing tag v1.3.2+8.16 ? You have incoherent numbering, and that makes it more difficult to auto-detect new releases, see the list of tags [Notice the two changes: - vs + and coq or not]

Thanks!

@lukaszcz
Copy link
Owner

lukaszcz commented Sep 5, 2022

This change to +8.16 was intentional and I intend to keep it in the future to avoid having branches and tags with the same name.

Can you just change your way of detecting new releases to use the new tag name format?

@SnarkBoojum
Copy link

Ah, if it's deliberate and intended for long-term, I definitely can adapt. Thanks!

@MSoegtropIMC
Copy link
Author

@lukaszcz : can you next time please leave the issue open until I updated Coq Platform (as requested in the text). I need this for book keeping to ensure I don't forget anything (just found this in double checking).

@MSoegtropIMC
Copy link
Author

I updated coq-hammer to v1.3.2-coq8.16 and z3_tptp to version 4.11.0.

@lukaszcz
Copy link
Owner

lukaszcz commented Sep 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants