Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support using Examples with Produces #1275

Merged
merged 2 commits into from
Jul 11, 2022
Merged

Conversation

YiTingLee
Copy link
Contributor

@YiTingLee YiTingLee commented Jun 28, 2022

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you written unit tests?
  • Have you written unit tests that cover the negative cases (i.e.: if bad data is submitted, does the library respond properly)?
  • This PR is associated with an existing issue?

Closing issues
closes #1269

Potential Problems With The Approach

Test plan

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello there YiTingLee 👋

Thank you and congrats 🎉 for opening your first PR on this project.✨

We will review the following PR soon! 👀

@WoH
Copy link
Collaborator

WoH commented Jul 4, 2022

Could you please add a test to show what is being fixed to avoid regressions?

@YiTingLee
Copy link
Contributor Author

Sure, I will add a test later. thanks

@YiTingLee
Copy link
Contributor Author

@WoH I added tests for this PR. Please review again, thanks!!

@WoH
Copy link
Collaborator

WoH commented Jul 11, 2022

LGTM, thank you!

@WoH WoH merged commit 057c57b into lukeautry:master Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using @Produces with @Example decorators causes error when generating spec
2 participants