Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for named exports in curly braces #3

Merged
merged 5 commits into from
Aug 19, 2020

Conversation

d-fischer
Copy link
Contributor

@d-fischer d-fischer commented Apr 19, 2020

This adds support for named exports like the following:

export { foo };

It also aliases the default export - if there's any - to module.exports.default for TypeScript interoperability without requiring the esModuleInterop option. Dropped this part from the PR after the conversation in lukeed/klona#17.

@codecov-commenter
Copy link

codecov-commenter commented Jul 3, 2020

Codecov Report

Merging #3 into master will increase coverage by 0.32%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #3      +/-   ##
==========================================
+ Coverage   66.66%   66.99%   +0.32%     
==========================================
  Files           1        1              
  Lines         102      103       +1     
==========================================
+ Hits           68       69       +1     
  Misses         34       34              
Impacted Files Coverage Δ
index.js 66.99% <100.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7228e27...5f4614d. Read the comment docs.

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@lukeed lukeed merged commit ac1d229 into lukeed:master Aug 19, 2020
lukeed added a commit that referenced this pull request Aug 19, 2020
- module.exports[key] === exports[key]
- enter via #3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants