Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add conditional exports #63

Closed
wants to merge 1 commit into from
Closed

Conversation

cometkim
Copy link

No description provided.

@remcohaszing
Copy link
Contributor

This PR breaks native ESM (.mjs extension is necessary) and TypeScript (CJS interface does not match ESM interface, although this was already broken) support. Also there there should be a "default" field, which should be the last key in the export map. Since this package doesn’t specify "type": "module", the file to resolve for require should he marked as "default".

I proposed a proper fix in #57, but the author has shown no interest to resolve this issue. This does not include exports for package.json as you added here.

@cometkim cometkim closed this Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants