-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updates for Node 14 and ESM #30
Conversation
… export maps fpr node 14 and above
Bench results with Node 14.
|
- single file source - use `export default` - ignore generated outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this. Hope you don't mind that I reduced some of the moving pieces. The ideas and the approaches are the same 👍
However, do you mind removing the test changes? I'm not opposed to the new tests (I'd have some suggestions for them), but they're not working in CI – and even if they were, it's too many large-scale moving chunks at once. I'd feel much better merging an exports
PR that proves existing usage is preserved (eg, everything via require; to start...).
I'd much rather look at & discuss test changes separately.
Hope you understand!
Also, the tests may be parallelized now, but they're significantly slower. Node 6 Node 14 |
Happy to disentangle. Will be able to look at this in a few days. |
- typescript can infer from this type correctly for ESM, CJS, and TS. Using `export default` produces type errors in CJS files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @kristoferbaxter :)
I'm going to make some additional changes that bring back your dual/native testing, but I don't want to include that noise here.
Appreciate your patience
tap
with parallelized testsvolta
for pinning node and yarn versionNOTE This PR isn't meant to be consumed as is, but as a heads up of how some of this might work.This PR is now ready for review, maintaining compatibility with older node versions but using ESM when available.
Closes #31