Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support NO_COLOR env var #37

Merged
merged 3 commits into from
Aug 13, 2020
Merged

Support NO_COLOR env var #37

merged 3 commits into from
Aug 13, 2020

Conversation

stramel
Copy link
Contributor

@stramel stramel commented Aug 13, 2020

@stramel stramel mentioned this pull request Aug 13, 2020
Merged
lukeed
lukeed approved these changes Aug 13, 2020
View reviewed changes
Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know about this. Thanks!

@lukeed
Copy link
Owner

lukeed commented Aug 13, 2020

I'm not sure if this should be considered a feature or a patch fix. What do you think?

@stramel
Copy link
Contributor Author

stramel commented Aug 13, 2020 •
edited
Loading

I would say feature but I could see people arguing it should have been supported already.

I also think it is small enough of a change, it could be pushed as a patch.

@lukeed
Copy link
Owner

lukeed commented Aug 13, 2020

Hmm... I think since NO_COLOR seems to be its own thing – site and all! – it probably justifies a feature label.

@lukeed lukeed merged commit d839af7 into lukeed:master Aug 13, 2020
@stramel stramel deleted the patch-1 branch August 13, 2020 02:54
@stramel
Copy link
Contributor Author

stramel commented Aug 13, 2020

Thanks for the quick review! I will submit a PR to that repo to add this package to the list of supported modules.

@lukeed
Copy link
Owner

lukeed commented Aug 13, 2020

Thank you x2 -- appreciate it~!

@lukeed
Copy link
Owner

lukeed commented Aug 13, 2020

Released in v4.1.0

@stramel
Copy link
Contributor Author

stramel commented Aug 13, 2020 •
edited
Loading

PR created: jcs/no_color#87

@chocolateboy chocolateboy mentioned this pull request Sep 25, 2020
Closed
@nerds-github nerds-github mentioned this pull request Oct 24, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukeed lukeed lukeed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stramel @lukeed