Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NO_COLOR handling to comply with the spec #40

Closed
wants to merge 1 commit into from
Closed

Fix NO_COLOR handling to comply with the spec #40

wants to merge 1 commit into from

Commits on Sep 26, 2020

  1. Fix NO_COLOR handling to comply with the spec 

    disable color with NO_COLOR:

before:

    $ NO_COLOR=1 command  # ✔
    $ NO_COLOR=0 command  # ✔
    $ NO_COLOR= command   # x
    $ NO_COLOR="" command # x

after:

    $ NO_COLOR=1 command  # ✔
    $ NO_COLOR=0 command  # ✔
    $ NO_COLOR= command   # ✔
    $ NO_COLOR="" command # ✔

also:

- don't equate FORCE_COLOR="" with FORCE_COLOR=1
- add environment-variable tests (based on ./test/env.sh)
    @chocolateboy
    chocolateboy committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    a5c6a2a View commit details
    Browse the repository at this point in the history