Fixed browser support #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #42 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 2 2
Lines 163 163
Branches 29 28 -1
=======================================
Hits 161 161
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
|
Hey :) Can we change these to |
|
Of course that will work too :) |
|
done |
lukeed
added a commit
to lukeed/uvu
that referenced
this pull request
Nov 9, 2020
* Stricter isNode check * fix: include `process.stdout` for `isNode` check related: lukeed/kleur#42 Co-authored-by: Luke Edwards <luke.edwards05@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey @lukeed how are you?
Every bundler like browserify, parcel and webpack is using a shim of
processthat doesn't havestdoutimplemented.So when I try to use kleur in the browser it throws an error that process.stdout is undefined.
With this minor change we can have support for the browser too.